fix: change the block-dynamic-connections plugin to use a connection previewer instead of monkey patching #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
requested review from
rachel-fenichel
and removed request for
a team
|
@rachel-fenichel Ready for re-review =) |
rachel-fenichel
approved these changes
Feb 5, 2024
This was referenced Feb 5, 2024
maribethb
pushed a commit
that referenced
this pull request
Feb 16, 2024
…previewer instead of monkey patching (#2190) * feat: add pass through previewer * fix: don't remove valid connections on saveExtraState * fix: have connection previewer handle pending connections * fix: have onPendingConnection ignore insertion markers * chore: delete insertion marker monkey patch * fixup * chore: bump versions * chore: fixup naming and docs * chore: format * chore: fix build * chore: fixup type * feat: make BasePreviewerConstructor optional * chore: fix readme * chore: PR nits
maribethb
added a commit
that referenced
this pull request
Feb 16, 2024
* fix: change the block-dynamic-connections plugin to use a connection previewer instead of monkey patching (#2190) * feat: add pass through previewer * fix: don't remove valid connections on saveExtraState * fix: have connection previewer handle pending connections * fix: have onPendingConnection ignore insertion markers * chore: delete insertion marker monkey patch * fixup * chore: bump versions * chore: fixup naming and docs * chore: format * chore: fix build * chore: fixup type * feat: make BasePreviewerConstructor optional * chore: fix readme * chore: PR nits * feat!: update block-dynamic-connection to use blockly v10.4.1 --------- Co-authored-by: Beka Westberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes google/blockly#7204
Proposed Changes + Reasons
Change the dynamic connections plugin to use a connection previewer so that we don't have to patch the insertion marker manager anymore.
Test Coverage
Manually tested.
I did find one issue with deleting blocks (inputs don't get removed when you delete) which was exposed by the changes to
saveStatewhere we don't callfinalizeConnectionsif the block is in the correct state. But this was only working because of how the advanced playground generates JSON on every workspace change. So I'm going to fix as a follow up.Documentation
N/A
Additional Information
N/A